Send warnings to stderr and in yellow color in test and compiler.erlang tasks #14018
Conversation
| IO.puts("#{file}:#{location_to_string(location)} warning: #{module.format_error(message)}") | ||
| message = "#{file}:#{location_to_string(location)} warning: #{module.format_error(message)}" | ||
|
|
||
| IO.puts(:stderr, IO.ANSI.format([:yellow, :bright, message])) |
There was a problem hiding this comment.
The Elixir compiler does not wrap the the whole message in yellow, only the warning part, not in bright, and it ultimately uses another format, so I am not sure we should go for consistency here. We should probably be more consistent with the Erlang compiler warnings and error messages instead.
There was a problem hiding this comment.
Well, I was going to mention that, but there are some parts where the whole warning is printed in yellow. So I was going to mention this in an issue itself. I can create the issue, or we can discuss it here.
There was a problem hiding this comment.
Those are different warnings emitted by different places, and different on purpose, since they have implications. I would prefer to stay consistent within each library: Erlang, Mix, and Elixir.
There was a problem hiding this comment.
I see. So what is the desired format for warnings in the Erlang and Mix library?
There was a problem hiding this comment.
Probably the formats that we have right now? :) although I will double check if the Erlang one is still relevant.
|
Closing this for now. If the Erlang warnings could be updated, it should be done to match the Erlang compiler, so it is separate from this PR. Thank you! |
|
@josevalim I was waiting for your answer regarding your last comment. #14018 (comment)
I don't get this, since this PR it solely about Compilers.Erlang warnings. |
|
This PR also changes In any case, Erlang warnings should be consistent with warnings emitted by the Erlang compiler. |
|
Oh.. I see. |
|
To be clear, the only change we agree at the moment is to make the output of compile.erlang closer to the output of |
|
What would be the reason to send warnings to stdio and not to stderr? |
|
Unless |
There warnings were being sent to stdio. I am redirecting them to stderr and with yellow color.